Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: organize skipping blockchain tests for EEST #262

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

Mdaiki0730
Copy link
Contributor

@Mdaiki0730 Mdaiki0730 commented Feb 21, 2025

Proposed changes

As mentioned in #238, we will enable the EEST blockchain test that we skipped.

  • Enable 7702 tests and 2537 tests (Except for calls to system contracts and type3)
  • There were some issues with the 7702, so this will fix them.
    • Prepared a simulation function for genesis.
      • If there was an empty account in genesis, useEthStateRoot deleted it.
    • Changing cast from SCA to ProgramAccount in snapshot.
      • After the introduction of 7702, if genesis contained EOAwithStorage, this was not recorded in the snap.
    • Allow set code tx to send to the zero address.
      • The validation of set code tx prohibited calls to the zero address.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mdaiki0730 Mdaiki0730 self-assigned this Feb 21, 2025
@Mdaiki0730 Mdaiki0730 marked this pull request as ready for review February 21, 2025 06:11
blukat29
blukat29 previously approved these changes Feb 21, 2025
Co-authored-by: Yunjong Jeong (ollie) <[email protected]>
@Mdaiki0730 Mdaiki0730 merged commit 34cc8d2 into kaiachain:dev Feb 21, 2025
9 checks passed
@Mdaiki0730 Mdaiki0730 deleted the feat/enable-skipped-eip branch February 21, 2025 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants