Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable prague's EIP7623 #214

Conversation

Mdaiki0730
Copy link
Contributor

@Mdaiki0730 Mdaiki0730 commented Jan 20, 2025

Proposed changes

This PR enables prague's EIP7623 test in eets blockchain tests.
There was a problem with the test process that has now been fixed.

  • It was not possible to create a block containing a transaction that returns an error using Generate chain. The test function makes this possible.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mdaiki0730 Mdaiki0730 changed the base branch from dev to feat/eets-blockchain-test January 20, 2025 10:28
@Mdaiki0730 Mdaiki0730 force-pushed the feat/enable-prague-7623 branch from c16f6c6 to 3a3b74b Compare January 20, 2025 10:38
@Mdaiki0730 Mdaiki0730 self-assigned this Jan 20, 2025
@Mdaiki0730 Mdaiki0730 marked this pull request as ready for review January 20, 2025 10:52
@Mdaiki0730 Mdaiki0730 merged commit 7db495f into kaiachain:feat/eets-blockchain-test Jan 20, 2025
9 checks passed
@Mdaiki0730 Mdaiki0730 deleted the feat/enable-prague-7623 branch January 20, 2025 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant