test: Enable Shanghai and Cancun EIPs blockchain test by Cancun and Prague forks #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mdaiki0730
force-pushed
the
feat/shanghai-cancun-eets
branch
4 times, most recently
from
930d209 to
abb1237
Compare
Mdaiki0730
force-pushed
the
feat/shanghai-cancun-eets
branch
from
9bd1211 to
877e495
Compare
Mdaiki0730
requested review from
blukat29,
yoomee1313 and
ian0371
as code owners
blukat29
reviewed
Jan 17, 2025
Comment on lines
+85
to
+87
| default: | ||
| // It's an EIP-2718 typed TX envelope. | ||
| // First read the tx payload bytes into a temporary buffer. |
There was a problem hiding this comment.
We must not decode 01~04 prefixes. It's Kaia's spec to disallow them. Because,
- Case A. allow both Eth and Kaia type bytes
f9... -> legacy
01... -> eth accesslist
08... -> kaia valuetransfer
what if Eth defines 08 in the future?
- Case B. Eth and Kaia types are distinguished with envelope
f9... -> legacy
01... -> disallowed
7801... -> eth accesslist
08... -> kaia valuetransfer
7808... -> eth type 8
and we chose type B in 2022. TxInternalDataSerializer.DecodeRLP accepting 0x01 prefix is an explicit spec violation. Please try to convert the test JSON, for instance,
- decode EthBlock RLP
- extract EthTx RLPs array
[][]bytes(don't further decode txs here) - attach 0x78 if first byte of each tx RLP is 01,02,03,04
- then decode into Kaia's
[]types.Transaction.
blukat29
reviewed
Jan 17, 2025
Comment on lines
+2779
to
+2782
| if UseKaiaCancunExtCodeHashFee && chainConfig.Rules(header.Number).IsCancun { | ||
| // EIP-1052 must be activated for backward compatibility on Kaia. But EIP-2929 is activated instead of it on Ethereum | ||
| vm.ChangeGasCostForTest(&vmenv.Config.JumpTable, vm.EXTCODEHASH, params.WarmStorageReadCostEIP2929) | ||
| } |
There was a problem hiding this comment.
If EIP-1052 fails, then let it fail and skip those JSONs (unless most tests fail due to 1052). The skip list is the accurate representation of Kaia's compatibility.
There was a problem hiding this comment.
then let it fail and skip it
Does it means vm.ChangeGasCostForTest?
Mdaiki0730
merged commit b474ad6
into
kaiachain:feat/eets-blockchain-test
9 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enables Shanghai, Cancun EETS blockchain testing with the Cancun and Prague forks.
The flow has been slightly changed to enable blockchain testing.
It includes some code to check for eth compatibility, but these may not be optimal.
Please review these only for the logic to proceed with the test task first.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...