Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix for glb bone rotation #40

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Hot fix for glb bone rotation #40

merged 1 commit into from
Jul 1, 2024

Conversation

nixon-voxell
Copy link
Collaborator

@nixon-voxell nixon-voxell commented Jul 1, 2024

Fix

Previously, bone animation always result in wrong rotation after applying to the glb model.

I applied a fix that resets all the rotation of the bones so that it aligns with the T-pose resting position from mixamo after exporting to bvh.

Changelog

  • Edit blender and glb file to rotate bones so that all bones default to (0, 0, 0) (pointing towards the z-axis in blender)
  • Remove "parent transform" added to scene for debug scene rotation.
  • Unhide MainScene entity.

@nixon-voxell nixon-voxell added the bug Something isn't working label Jul 1, 2024
@nixon-voxell nixon-voxell self-assigned this Jul 1, 2024
@kahboon0425 kahboon0425 merged commit dafc259 into main Jul 1, 2024
6 checks passed
@kahboon0425 kahboon0425 deleted the fix/glb-bone-rotation branch July 1, 2024 08:06
@nixon-voxell nixon-voxell added this to the v0.1.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants