feat(helm): add optional PodDisruptionBudget for the controller - #140
Open
anthonyhaussman wants to merge 1 commit into
Open
feat(helm): add optional PodDisruptionBudget for the controller#140anthonyhaussman wants to merge 1 commit into
anthonyhaussman wants to merge 1 commit into
Conversation
Node drains and cluster upgrades can evict every controller replica at once. An opt-in PodDisruptionBudget lets operators keep a minimum number of replicas scheduled during voluntary disruptions. Disabled by default, so existing installs render an identical manifest set. The template rejects setting both minAvailable and maxUnavailable, or neither, because the API server accepts exactly one of them. Assisted-by: Claude Opus 5 Signed-off-by: Anthony Hausman <anthonyhaussmann@gmail.com>
anthonyhaussman
force-pushed
the
feat/helm-pod-disruption-budget
branch
from
August 6, 2026 04:50
c6a451b to
792da57
Compare
anthonyhaussman
marked this pull request as ready for review
August 6, 2026 04:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
PodDisruptionBudgetfor the kmcp controller-manager pods.Node drains and cluster upgrades can currently evict every controller replica at once. A
PodDisruptionBudgetlets operators keep a minimum number of replicas scheduled during voluntary disruptions.The feature is disabled by default, so existing installs render an identical manifest set.
Design notes
kmcp.selectorLabels, the same helper the Deployment uses, so the budget matches exactly the controller pods.minAvailableandmaxUnavailableare mutually exclusive at the API level, so the chart fails at render time when both or neither is set, rather than deferring the error to the API server.kmcp.pdb.isSettreats the integer0as a set value while rejectingniland"", somaxUnavailable: 0is not silently dropped.unhealthyPodEvictionPolicyis omitted from the manifest unless set, keeping the output valid on clusters older than 1.27.policy/v1(Kubernetes 1.21+) without apolicy/v1beta1fallback. The resource is opt-in and the beta API has been removed since 1.25.