feat: add helm values to configure pgx connection - #2399
Open
supreme-gg-gg wants to merge 4 commits into
Open
Conversation
supreme-gg-gg
changed the title
supreme-gg-gg
marked this pull request as ready for review
August 7, 2026 14:29
github-actions
Bot
added
enhancement
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
supreme-gg-gg
force-pushed
the
feat/postgres-connection
branch
from
August 7, 2026 14:48
a70aa0e to
6a00170
Compare
github-actions
Bot
added
enhancement
iplay88keys
reviewed
Aug 7, 2026
| VectorEnabled: cfg.Database.VectorEnabled, | ||
| } | ||
| if cfg.Database.MaxConns > 0 { | ||
| v := int32(cfg.Database.MaxConns) |
Contributor
There was a problem hiding this comment.
For each of these, we should probably have an upper bound as well. At least since an int converted to an int32 can truncate. Probably not an issue in practice, though, as that is an incredibly large number.
Contributor
Author
There was a problem hiding this comment.
I don't think that would be a realistic config though
iplay88keys
reviewed
Aug 7, 2026
|
|
||
| // postgresConfigFromApp builds a database.PostgresConfig from app flags. | ||
| // Zero/unset flag values leave the corresponding pool field nil so pgx defaults apply. | ||
| func postgresConfigFromApp(dbURL string, cfg *Config) *database.PostgresConfig { |
Contributor
There was a problem hiding this comment.
We should definitely validate that minConns is greater than maxConns if minConns is set.
Contributor
Author
There was a problem hiding this comment.
fair point, added the check
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This targets 0.10.x release.
Verified with
pg_stat_activitythat connection is closed after configured idle timeout + pgx check period