-
-
Notifications
You must be signed in to change notification settings - Fork 155
FE: Wizard: Update jaas.config for GCP managed Kafka (per Google docs) #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Per GCP docs this is the correct JaasConfig: https://cloud.google.com/managed-service-for-apache-kafka/docs/quickstart-java#configure_and_run_the_application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi mike-pt! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
@Muchembi hi, could you take a look please? |
@mike-pt could you fix the linter issues please? |
sorry @Haarolean I missed the notification at the time, I see indentation was not correct thanks for fixing |
Per GCP docs this is the correct JaasConfig:
https://cloud.google.com/managed-service-for-apache-kafka/docs/quickstart-java#configure_and_run_the_application
What changes did you make? (Give an overview)
Fixed the JaasConfig for GCP managed Kafka
Is there anything you'd like reviewers to focus on?
Yes Google doc states this:
If I got it correct "required" is already appended so I don't need to add it in this line, please confirm as I'm not to familiar with the code.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
The generated config was failing and changing this line fixed it.
NOT WORKING:
WORKING:
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct