Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add safe assign line to make sure map is not trying to loop on top of undefined #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add safe assign line to make sure map is not trying to loop on top of undefined #143

wants to merge 1 commit into from

Conversation

alansikora
Copy link

Fixes issue #142.

@brettle
Copy link

brettle commented Dec 8, 2015

This PR will squash the error but will not necessarily produce the correct behavior because the document that is supposed to be changed will not actually be changed.

PR #154 provides a more complete fix to issue #142. It ensures that the document will be changed, only permits the change if the document exists in the current publication context or another one, and also prevents similar problems with removed().

FYI, issue #142 is actually triggered by my brettle:accounts-login-state package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants