Lack of precision vuln updated to precision loss. #86
Conversation
vulnerabilities/precision-loss.md
Outdated
| ``` | ||
| and ``funcB()`` returns: | ||
| ```solidity | ||
| 11 * 2 / 10 = 55 |
There was a problem hiding this comment.
This should actually return 2. I think your example is mixed up
There was a problem hiding this comment.
Yeah, Fixed in the latest commit!
| @@ -0,0 +1,44 @@ | |||
| # Using ``msg.value`` in a Loop | |||
There was a problem hiding this comment.
Will have to merge/rebase to remove this file
There was a problem hiding this comment.
Fixed in the latest commit!
There was a problem hiding this comment.
Looks like it's still included for some reason. Just me?
There was a problem hiding this comment.
There are no changes in the latest commit for msgvalue-loop.md file but file changes shows msgvalue-loop.md file being updated.
Also, Nothing seems to work even after merging and rebasing with both msgValue and master branch. I think it is because one commit from msgValue got included here and it is causing the problem. As this PR has no conflicts with the base branch, and msgvalue-loop.md content hasn't been changed and is similar to the master branch, it can be merged without any issues.
Or we can close this PR and create a new one.
Related Issue
Checklist
Describe the changes you've made:
I added precision loss due to solidity decimal truncation vulnerability including various ways this can occur.
Type of change
Select the appropriate checkbox:
Additional Information
I thought the title needed some change so I changed it to
Precision Loss. You suggestedInteger RoundingandInteger truncationwhich are good for root cause but precision loss and rounding errors represent the actual vulnerability. Let me know if I should revert back to the root cause titles.