fix hyperlane gas tests #1359
Merged
fix hyperlane gas tests #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xd34df00d
approved these changes
Mar 27, 2024
rsoeldner
force-pushed
the
rsoeldner/fix-tests-hyperlane
branch
from
1af7316 to
3835bc8
Compare
rsoeldner
commented
Apr 2, 2024
src/Pact/Native.hs
Outdated
| @@ -146,7 +147,7 @@ nativeDefs :: HM.HashMap Text Ref | |||
| nativeDefs = mconcat $ map moduleToMap (hyperlaneDefs:natives) | |||
|
|
|||
| pact412NativeDefs :: HM.HashMap Text Ref | |||
| pact412NativeDefs = mconcat $ map moduleToMap $ hyperlaneAmendedDefs:natives | |||
| pact412NativeDefs = foldMap moduleToMap $ hyperlaneAmendedDefs:natives | |||
There was a problem hiding this comment.
Addresses @0xd34df00d comment in #1358
jmcardon
reviewed
Apr 2, 2024
| absent li name = case (Map.lookup name defaultGasTable) of | ||
| Nothing -> name : li | ||
| Just _ -> li | ||
| absentNatives = foldl' absent [] justNatives | ||
| (S.fromList absentNatives) | ||
| `shouldBe` | ||
| (S.fromList ["CHARSET_ASCII", "CHARSET_LATIN1", "public-chain-data", "list"]) | ||
| (S.fromList ["CHARSET_ASCII", "CHARSET_LATIN1" | ||
| ,"hyperlane-token-erc20", "hyperlane-token-msg" |
There was a problem hiding this comment.
👍 LGTM. For any future readers: these two are schemas.
jmcardon
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: