Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: share code between verifier and signature scoping #1343

Closed
wants to merge 1 commit into from
Closed

refactor: share code between verifier and signature scoping #1343

wants to merge 1 commit into from

Conversation

edmundnoble
Copy link
Contributor

PR checklist:

  • Test coverage for the proposed changes

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat - did a replay

emilypi
emilypi requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@emilypi emilypi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs replay - hasn't been confirmed in its current state.

@edmundnoble
Copy link
Contributor Author

Not going in this release it seems, just being conservative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilypi emilypi emilypi requested changes

@jmcardon jmcardon jmcardon approved these changes

@jwiegley jwiegley jwiegley approved these changes

@sirlensalot sirlensalot Awaiting requested review from sirlensalot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundnoble @jwiegley @emilypi @jmcardon