Tweak cost of running concat
#1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imalsogreg
requested review from
sirlensalot,
jwiegley,
emilypi and
jmcardon
as code owners
rsoeldner
reviewed
Aug 7, 2023
jmcardon
reviewed
Aug 7, 2023
emilypi
reviewed
Aug 7, 2023
src/Pact/Native.hs
Outdated
| in | ||
| GTextConcatenation nChars nStrings | ||
| computeGas' i concatGasCost $ let | ||
| ls' = V.toList ls |
There was a problem hiding this comment.
Why are we turning it into a list here?
There was a problem hiding this comment.
We pass ls' to T.concat, and contrary to what you'd expect T.concat is monomorphic and demands a list.
There was a problem hiding this comment.
really that's intense. I don't want to armchair microbench but i'd assume vector concat and then a single toList call woudl be better, but I'm not going to stall the PR over it
jmcardon
approved these changes
Aug 7, 2023
emilypi
approved these changes
Aug 7, 2023
jwiegley
approved these changes
Aug 7, 2023
imalsogreg
force-pushed
the
greg/gas-concat
branch
from
57348e6
to
15abaf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the gas costing for the
concatbuiltin to account for both the number of strings being concatenated, and the length of those strings.PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: