Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pact -s #201

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

add pact -s #201

wants to merge 15 commits into from

Conversation

rsoeldner
Copy link
Member

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon mentioned this pull request Aug 8, 2024
Closed
6 tasks
jmcardon
jmcardon reviewed Aug 27, 2024
View reviewed changes
pact-request-api/Pact/Core/Command/Server/Config.hs
, _logDir :: FilePath
-- , _pragmas :: [Pragma]
-- , _verbose :: Bool
-- , _gasLimit :: Maybe Int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GasLimit and gas rate are commented?

pact-request-api/Pact/Core/Command/Server/Config.hs
, _persistDir :: Maybe FilePath
, _logDir :: FilePath
-- , _pragmas :: [Pragma]
-- , _verbose :: Bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did this flag used to signify?

pact-request-api/Pact/Core/Command/Server/Config.hs
-- <*> o

-- validateConfigFile :: FilePath -> IO Config
-- validateConfigFile fp = Y.decodeFileEither fp >>= \case
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed?

repl/Main.hs
OServer configPath -> Y.decodeFileEither configPath >>= \case
Left perr -> putStrLn $ Y.prettyPrintParseException perr
Right config -> runServer config
--do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcardon jmcardon jmcardon left review comments

@jwiegley jwiegley Awaiting requested review from jwiegley jwiegley will be requested when the pull request is marked ready for review jwiegley is a code owner

@emilypi emilypi Awaiting requested review from emilypi emilypi will be requested when the pull request is marked ready for review emilypi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsoeldner @jmcardon