Introduce Depth and Limit newtypes for Pact Service
#1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
local-rewind-depth-better-types
branch
3 times, most recently
from
f7282d7
to
fe9cb3e
Compare
ghost
marked this pull request as ready for review
emilypi
reviewed
Jun 14, 2023
edmundnoble
reviewed
Jun 20, 2023
edmundnoble
approved these changes
Jun 20, 2023
ghost
force-pushed
the
local-rewind-depth-better-types
branch
from
481c820
to
3bc7fd0
Compare
ghost
force-pushed
the
local-rewind-depth-better-types
branch
from
3bc7fd0
to
c859407
Compare
emilypi
approved these changes
Jun 21, 2023
chessai
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two newtypes (wrappers around
Word64) to provide better semantics in the pact service:Depth— sometimes the operation goes backwards and usesBlockHeightwhich is semantically ambiguous,Depthshould help with it.Limit— representation for a restriction value.