Add Verifiers to TxDetail #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add _txDetail_verifiers field
enobayram
reviewed
Apr 11, 2024
lib/ChainwebData/TxDetail.hs
Outdated
| @@ -49,6 +49,7 @@ data TxDetail = TxDetail | |||
| , _txDetail_previousSteps :: Maybe [Text] | |||
| , _txDetail_signers :: [Signer] | |||
| , _txDetail_sigs :: [Sig] | |||
| , _txDetail_verifiers :: Maybe Value | |||
There was a problem hiding this comment.
I think we can do better than this. These verifiers are conceptually similar to signers, so we probably need a Verifier data type and a database table to go with it.
There was a problem hiding this comment.
While we could indeed consider adding verifiers as a new column to the transactions table, I think there's good reason to keep it in a separate table like the signers table, because there can be multiple verifiers in a given transaction and if one wanted to index by, say, the verifier name, that would be impossible to do via the transactions table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add _txDetail_verifiers field