Revert "Fix symbol regex and format json file" #11
Conversation
| "patterns": [ | ||
| { | ||
| "begin": "'", | ||
| "end": "(?=\\s|[],:\"'.)])", |
There was a problem hiding this comment.
This regex doesn't seem correct to me, it has a closing parenthesis to many. Did you intend the closing parenthesis to be escaped?
There was a problem hiding this comment.
@EnoF it is correct.
"You can include an unescaped closing bracket by placing it right after the opening bracket, or right after the negating caret. []x] matches a closing bracket or an x." source: https://www.regular-expressions.info/charclass.html
It's preferable to use the specific syntax that avoids unwieldy escape sequences.
There was a problem hiding this comment.
See also:
#3
The Pact extension for Atom had initially the same issue, let me refer this earlier exchanges:
kadena-io/pact-atom#9
There was a problem hiding this comment.
The ultimate review of the actual functionality is of course building the extension at the specific point commit using VSCE command and install it locally in VS Code.
Reverts #10
The change is just not needed, it lowers the readability of the regex changed and the way it was applied -mixing formatting with attempts at fixing something- is bad practice with regard to change management. If there is a "distinct behavior", which I couldn't identify so far, it should be possible to describe it.