-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changesets #712
Merged
Merged
Add changesets #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
webpro
force-pushed
the
chore/add-changesets
branch
2 times, most recently
from
August 3, 2023 07:53
dbb17ac
to
3effe2b
Compare
webpro
force-pushed
the
chore/migrate-away-from-rush
branch
5 times, most recently
from
August 10, 2023 09:27
1ed5fa2
to
b91e8aa
Compare
webpro
force-pushed
the
chore/add-changesets
branch
from
August 10, 2023 13:14
32f3e6d
to
7bbd599
Compare
webpro
force-pushed
the
chore/add-changesets
branch
from
August 28, 2023 13:58
7bbd599
to
fd0b600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #612 and targeting that branch.
This PR introduces Changesets to handle our changelog and package publishing needs. Please read some of the docs to get an idea of what it is all about. Here's a an article with a quick rundown: Ditching manual releases with Changesets.
Also see #612 + comments for additional context. This PR contains:
.changesets/*.md
files (the equivalent ofcommon/changes/**/*.json
in Rush projects).main
branch.GITHUB_TOKEN
andNPM_TOKEN
.Three workflows:
When we open new pull requests we can add a changeset (the equivalent of
rush change
):After merging this PR we can install the Changesets bot which comments on PRs that don't contain a changelog (the equivalent of
rush change --verify
). So with normal settings developers will be notified in the PR itself + email.Extra scripts
Convert Rush changelog (
common/changes/**/*.json
) to Changesets (.changesets/*.md
) format:Generate
packages.json
in root:Publish one, set, or all packages (from root):
Notes
ignore
option to exclude "everything else" from being versioned and published.CHANGELOG.md
in each package. We can remove theCHANGELOG.json
files as we go.Preview
To get an idea of what publishing looks like, here's a screenshot with the current settings:
The
pnpm publish-set
is a script that basically adjusts theignore: []
config of Changesets in case we don't want to publish everything. Run this script which will populate theconfig: []
with everything we won't publish (yes it's a hack) and runs the regular Changesetsversion
+publish
flow afterwards: