feat(explorer): add funcitonality to remove networks #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2529df6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/apps/explorer/src/components/routing/useRouter.tsx # packages/apps/explorer/src/components/select-network/select-network.tsx # packages/apps/explorer/src/context/networks-context.tsx
# Conflicts: # packages/apps/explorer/src/components/select-network/new-network.tsx # packages/apps/explorer/src/context/networks-context.tsx
Randynamic
approved these changes
Jul 22, 2024
I will share the new design for this. this was already changing |
eileenmguo
reviewed
Jul 22, 2024
Comment on lines
+250
to
+272
| <CardFooter> | ||
| {!isDefaultNetwork(network) && !network.isNew && ( | ||
| <Button onPress={handleRemove} variant="negative"> | ||
| Remove | ||
| </Button> | ||
| )} | ||
| <Stack flex={1} /> | ||
|
|
||
| {!isDefaultNetwork(network) && ( | ||
| <> | ||
| <Button | ||
| onPress={() => { | ||
| handleOpen(false); | ||
| }} | ||
| variant="outlined" | ||
| > | ||
| Cancel | ||
| </Button> | ||
| <Button type="submit"> | ||
| {!network.isNew ? 'Update network' : 'Create Network'} | ||
| </Button> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Are you trying to have buttons with space between? If so, there should be a prop on the CardFooter that allows for this (separated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1205801361945248/1207765395158110/f