-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explorer): add funcitonality to remove networks #2401
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2529df6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/apps/explorer/src/components/routing/useRouter.tsx # packages/apps/explorer/src/components/select-network/select-network.tsx # packages/apps/explorer/src/context/networks-context.tsx
# Conflicts: # packages/apps/explorer/src/components/select-network/new-network.tsx # packages/apps/explorer/src/context/networks-context.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<CardFooter> | ||
{!isDefaultNetwork(network) && !network.isNew && ( | ||
<Button onPress={handleRemove} variant="negative"> | ||
Remove | ||
</Button> | ||
)} | ||
<Stack flex={1} /> | ||
|
||
{!isDefaultNetwork(network) && ( | ||
<> | ||
<Button | ||
onPress={() => { | ||
handleOpen(false); | ||
}} | ||
variant="outlined" | ||
> | ||
Cancel | ||
</Button> | ||
<Button type="submit"> | ||
{!network.isNew ? 'Update network' : 'Create Network'} | ||
</Button> | ||
</> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you trying to have buttons with space between? If so, there should be a prop on the CardFooter that allows for this (separated)
https://app.asana.com/0/1205801361945248/1207765395158110/f