Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up client-utils into modules so functions are h2 #2275

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lsgunnlsgunn
Copy link
Contributor

Built-in module in client utils

Related Issue/Asana ticket: _

Short description: _

Test scenarios

  • description of the (manually) executed test scenarios

Reminders (if applicable)

  • I ran pnpm install and pnpm test in the root of the monorepo
    (optionally with --filter=...package... to exclude non-affected
    projects)
  • I ran pnpm changeset in the root of the monorepo
  • Test coverage has not decreased
  • Docs have been updated to reflect changes in PR (don't forget
    docs.kadena.io)

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
kode-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
marmalade-marketplace ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
proof-of-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
react-ui ⬜️ Ignored (Inspect) Aug 29, 2024 3:54pm

Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: 25eecc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lsgunnlsgunn
Copy link
Contributor Author

@javadkh2 I've been thinking about splitting up the client-utils reference section into the different modules. I just did a first pass through what the Marmalade team put together for their functions, so I thought I would take a stab at the built-in modules.
When you get a chance, can you take a look and correct my mistakes and maybe point me to some simple examples?
Not urgent, just something I've been meaning to take another crack at.

Copy link
Contributor

This PR is stale because it is open for 60 days with no activity

@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace August 28, 2024 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – dev-wallet August 28, 2024 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer August 28, 2024 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – tools August 28, 2024 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us August 28, 2024 21:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant