Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/stepper component #2204

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Feat/stepper component #2204

wants to merge 10 commits into from

Conversation

ferreroltd
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 29, 2024 2:54pm
marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 2:54pm
proof-of-us ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 2:54pm
react-ui ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 2:54pm
tools ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 2:54pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 29, 2024 •
edited

⚠️ No Changeset found

Latest commit: 7c22fa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ferreroltd
ferreroltd commented May 29, 2024
View reviewed changes
packages/apps/dev-wallet/src/pages/signature-builder/signature-builder.tsx
<Wizard
steps={[
{ title: 'Paste Data' },
{ title: 'Add Signers' },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

ferreroltd
ferreroltd commented May 29, 2024
View reviewed changes
packages/apps/dev-wallet/src/Components/Wizard/components/Wizard-step.tsx
import { WizardElementProps } from '../model';

export const WizardStep: FC<WizardElementProps> = ({
children,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass id and title, the goto will find the step name and navigate to it

ferreroltd
ferreroltd commented May 29, 2024
View reviewed changes
packages/apps/dev-wallet/src/Components/Wizard/Wizard.tsx

export const Wizard: FC<WizardProps> = ({
children,
steps,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need

ferreroltd
ferreroltd commented May 29, 2024
View reviewed changes
packages/apps/dev-wallet/src/Components/Wizard/Wizard.tsx
return null;
}

if (child.type === Wizard.Step) {
if (child.type === WizardStep) {
stepIndex++;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluate from children.props.id and track the order

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ferreroltd