chore(@kadena/react-ui): Add more style props to Box component #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmguo
requested review from
sstraatemans and
salamaashoush
as code owners
🦋 Changeset detectedLatest commit: 46b1624 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
EnoF
approved these changes
Nov 9, 2023
sstraatemans
approved these changes
Nov 14, 2023
eileenmguo
force-pushed
the
chore/add-box-props
branch
from
75dde59
to
46b1624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Box component to accept more style properties like position, backgroundColor, border styles, etc.
Previously we had decided that the layout components should be used strictly for layout and I think that still should be the case for Stack and Grid components, however, I think we can let the Box component be more flexible so it can be used for more basic styles. At the moment, I think the value outweighs the downsides