-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiarch images #324
base: master
Are you sure you want to change the base?
Conversation
d51fafe
to
03def7d
Compare
This commit alters the Dockerfile for both regular and OpenShift in such a way multiarch images are getting built when using buildkit. Also, the GH workflow actually building the images is prepared for that. Fixes k8snetworkplumbingwg#226 Signed-off-by: Jorik Jonker <[email protected]>
This is needed to test/use the workflow in forks. Signed-off-by: Jorik Jonker <[email protected]>
Some were giving warnings about deprecated features Signed-off-by: Jorik Jonker <[email protected]>
Signed-off-by: Jorik Jonker <[email protected]>
03def7d
to
b77bbe5
Compare
I think I'm done now, it's ready for review |
Anything else I can do, @maiqueb? |
It is kind of annoying that this PR has partly been superseded by #329 and rebasing my PR requires a total rewrite now... I'm willing to rebase/refresh the part that is still left (combine Dockerfile/Dockerfile.arm64 and eliminate QEMU by having go cross compile), but only if someone is actually going to take a look at it (@maiqueb or @dougbtv). Please let me know if this is the case. |
I apologize for that. I can take a look at it if you eliminate the QEMU dependency from this repo. |
Thanks for the rebase, and apologies for the lack of coordination. Next time, feel free to join the Multus maintainer's call (info @ https://github.com/k8snetworkplumbingwg/community ) if you're relying on an update that isn't merged or isn't getting traction. |
What this PR does / why we need it:
This PR alters the Dockerfiles for both regular and OpenShift in such a way multiarch images are getting built when using buildkit. Also, the GH workflow actually building the images is prepared for that.
Also, I did a bit of cleaning up to ease testing.
Which issue(s) this PR fixes
Fixes #226
Special notes for your reviewer (optional):
docker buildx build --platform linux/amd64,linux/arm64 --file <dockerfile>
)-amd64
/-arm64
are gone, as the image contains bothRUN mkdir
in that dockerfile