Parameterize config watcher loop speed #1322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbtv
requested changes
Aug 29, 2024
| @@ -627,6 +627,10 @@ master CNI configuration and kubeconfig. when such change detected, the script w | |||
|
|
|||
| --skip-config-watch | |||
|
|
|||
| The poll interval of the config changes watcher is configurable with `--multus-config-watch-timer=<duration>` | |||
|
|
|||
There was a problem hiding this comment.
Let's also provide a link to whatever appropriate go docs about what are valid values for "duration" here. Otherwise, lgtm
There was a problem hiding this comment.
@dougbtv Thanks. I've updated the description with the go doc link for the duration. Please let me know if any suggestions.
There was a problem hiding this comment.
@dougbtv Thanks for reviewing the PR. Can we merge the PR or is there something can do to make it better?
mingshuoqiu
force-pushed
the
param-config-watcher-interval
branch
from
73d11b8
to
bdb8e19
Compare
This loop spins really quickly otherwise. This will allow cluster operators to choose how quickly the thin plugin reconciles the kubeconfig in the event of a stale service account token. BUG: k8snetworkplumbingwg#1232 Signed-off-by: Connor Kuehl <[email protected]> Signed-off-by: Chris Chiu <[email protected]>
mingshuoqiu
force-pushed
the
param-config-watcher-interval
branch
from
bdb8e19
to
0b2b14d
Compare
|
rebase on top of the latest adfb270 of k8snetworkplumbingwg:master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR is #1232. This PR rebase the commit on top of the current master.
This loop spins really quickly otherwise. This will allow cluster operators to choose how quickly the thin plugin reconciles the kubeconfig in the event of a stale service account token.