-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deploy file: use install_multus bin to update cni file #1213
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @41tair, thank you for the PR!
Once we use install_multus
for thick pluigin, then we could change container base image to distroless from
multus-cni/images/Dockerfile.thick
Line 10 in ba18cf5
FROM debian:stable-slim |
to such like that as thin Dockerfile
Line 11 in ba18cf5
FROM gcr.io/distroless/base-debian11:latest |
Could you pelase take care of that?
Anything left to do on this? Think mode seems broken/risky without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the update
Reluctant to deploy a new instance of multus until this bug is fixed. |
Would love to see this fixed. |
/cc @s1061123 May I ask why this PR is blocked? It actually fixes a critical bug. |
@dougbtv can we merge this and release a new image ? it is a critical bug fix right? |
Hey maintainers, can we please get some action on this?!?!?!?!?!?!?!?! People are tired of manually patching and fixing their installs.. Merge. The. Fix. |
@s1061123 sorry to bother you but please give a statement about this, it's breaking a lot of clusters. What has to be done to get this merged ? |
install cni initcontiainer can't execute sometimes
a sample error logs looks like:
cp: cannot create regular file '/host/opt/cni/bin/multus-shim': Text file busy
Fixes #1221