Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deploy file: use install_multus bin to update cni file #1213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

41tair
Copy link

@41tair 41tair commented Jan 19, 2024

install cni initcontiainer can't execute sometimes

a sample error logs looks like:

cp: cannot create regular file '/host/opt/cni/bin/multus-shim': Text file busy

Fixes #1221

@coveralls
Copy link

coveralls commented Feb 1, 2024

Coverage Status

coverage: 63.051% (-0.4%) from 63.432%
when pulling efa51cf on 41tair:fix/use-multus-install
into 3477c9c on k8snetworkplumbingwg:master.

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @41tair, thank you for the PR!

Once we use install_multus for thick pluigin, then we could change container base image to distroless from

FROM debian:stable-slim

to such like that as thin Dockerfile

FROM gcr.io/distroless/base-debian11:latest

Could you pelase take care of that?

@41tair 41tair requested a review from s1061123 February 21, 2024 06:02
@kfox1111
Copy link

Anything left to do on this? Think mode seems broken/risky without it.

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update

@kfox1111
Copy link

Reluctant to deploy a new instance of multus until this bug is fixed.

@dustinrouillard
Copy link

Reluctant to deploy a new instance of multus until this bug is fixed.

Would love to see this fixed.

@hansbogert
Copy link

as an end-user I'm wondering what's blocking this? I'm kinda stuck, 4.0.2 is non working for my cluster, but so is master, b/c of this: #1221

#1221 mentions that that issue should be fixed by this change

@iiiceoo
Copy link

iiiceoo commented Aug 13, 2024

/cc @s1061123 May I ask why this PR is blocked? It actually fixes a critical bug.

@sandj1438
Copy link

@dougbtv can we merge this and release a new image ? it is a critical bug fix right?

@dustinrouillard
Copy link

Hey maintainers, can we please get some action on this?!?!?!?!?!?!?!?! People are tired of manually patching and fixing their installs.. Merge. The. Fix.

@kub3let
Copy link

kub3let commented Nov 24, 2024

@s1061123 sorry to bother you but please give a statement about this, it's breaking a lot of clusters.

What has to be done to get this merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race issue after node reboot
10 participants