Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make language a list in evaluate app, added comments to evaluate description #25

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

fasterinnerlooper
Copy link
Contributor

No description provided.

@k4black k4black changed the title Reworked code so that it can run the metric. Added comments for fellow developers to use the metric correctly. fix: Reworked code so that it can run the metric. Added comments for fellow developers to use the metric correctly. Feb 1, 2024
@k4black k4black changed the title fix: Reworked code so that it can run the metric. Added comments for fellow developers to use the metric correctly. fix: Make language a list in evaluate app, added comments to evaluate description Feb 1, 2024
@fasterinnerlooper
Copy link
Contributor Author

Hey @k4black. There seems to be a filename conflict with building wheel during the CI build. Should it be overwritten or should it be skipped? https://github.com/k4black/codebleu/actions/runs/7736021887/job/21096507552

@k4black
Copy link
Owner

k4black commented Feb 2, 2024

@fasterinnerlooper Thank you for the contribution! Just fixed github actions (hopefully). I've updated your branch, will check pipeline status in ~15m

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6e250e) 43.56% compared to head (4e0c18a) 43.56%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   43.56%   43.56%           
=======================================
  Files          11       11           
  Lines        1538     1538           
=======================================
  Hits          670      670           
  Misses        868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k4black k4black merged commit 0ad3a2b into k4black:main Feb 2, 2024
26 checks passed
@fasterinnerlooper fasterinnerlooper deleted the FixLanguageArrayIssue branch March 22, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants