Remove secrets encryption controller

[dereknola]

Proposed Changes

• Background: The improved performance of secrets reencryption via Use higher QPS for secrets reencryption #10571, and a better understanding that the server handlers already exist as a separate go routine enable this PR
• Remove secrets reencryption controller and incorporate it directly into the handler like the other stages/cli commands.

Types of Changes

Code simplification

Verification

CI still green

Testing

This is covered by existing E2E and integration tests

Linked Issues

#10581

User-Facing Change

Further Comments

[brandond]

couple minor nits, lgtm otherwise!

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes missing coverage. Please review.

Project coverage is 43.68%. Comparing base (bffdf46) to head (09b0a0b).
Report is 30 commits behind head on master.

Files	Patch %	Lines
pkg/server/secrets-encrypt.go	0.00%	75 Missing ⚠️
pkg/secretsencrypt/config.go	0.00%	3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bffdf46) and HEAD (09b0a0b). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (bffdf46)	HEAD (09b0a0b)
e2etests	7	6

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10612      +/-   ##
==========================================
- Coverage   49.52%   43.68%   -5.84%     
==========================================
  Files         179      178       -1     
  Lines       14955    14890      -65     
==========================================
- Hits         7406     6505     -901     
- Misses       6193     7189     +996     
+ Partials     1356     1196     -160     

Flag	Coverage Δ
e2etests	36.43% <0.00%> (-9.78%)	⬇️
inttests	36.87% <0.00%> (+0.18%)	⬆️
unittests	13.47% <0.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brandond]

one more nit on error events