Add a change for killall to not unmount server and agent directory

[vitorsavian]

Proposed Changes

• Since our kill all script unmount and delete the entire /var/lib/rancher/k3s directory, the main idea is to remove the unmount and delete.
• Add a cleaner for mounted dirs when using the uninstall script

Types of Changes

• Changes to killall script to not delete anything inside /var/lib/rancher
• Changes to uninstall script to not delete mounted dirs inside /var/lib/rancher

Verification

• install k3s using my commit and then use the killall script
• uninstall k3s with the uninstall script

Testing

Linked Issues

• Killall script should not unmount /var/lib/rancher/k3s/(server|agent) #8527

User-Facing Change

Further Comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.54%. Comparing base (82ba778) to head (41917b2).

❗ There is a different number of reports uploaded between BASE (82ba778) and HEAD (41917b2). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (82ba778)	HEAD (41917b2)
e2etests	7	6

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10403      +/-   ##
==========================================
- Coverage   49.68%   43.54%   -6.15%     
==========================================
  Files         179      179              
  Lines       14955    14955              
==========================================
- Hits         7431     6512     -919     
- Misses       6166     7250    +1084     
+ Partials     1358     1193     -165     

Flag	Coverage Δ
e2etests	36.33% <ø> (-10.05%)	⬇️
inttests	36.72% <ø> (+0.05%)	⬆️
unittests	13.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brandond]

1. Need to account for possibility of arbitrary other mounted paths, not just the agent and server dirs.
2. Need to account for data and storage dirs under /var/lib/rancher/k3s

[brandond]

wait wait wait, we put this in the killall script... so now whenever you run the killall script it deletes all of K3s off your node. This makes sense to do in the uninstaller but the killall script DEFINITELY shouldn't be deleting everything out from under /var/lib/rancher/k3s otherwise you end up wiping your cluster off the face of the earth when all you wanted to do was kill the pods and service.

[vitorsavian]

@brandond when you said about deleting everything inside the /var/lib/rancher/k3s means also for the data and storage? btw I added the clean_mounted_directory to the uninstall script.

[brandond]

thanks! Sorry, I realize my review here has not been great, I forgot that we were talking about killall and not just uninstall.

[brandond]

This looks good to me but I'd like someone from QA to validate it on a couple different distros with different disks mounted under /var/lib/rancher/ just to validate that I haven't missed anything - prior to merging.

[vitorsavian]

@brandond after the merge of #10473 will we affect rancher if we change again to not delete anything when running killall?

[brandond]

I think it should be OK?

[fmoral2]

This looks good to me but I'd like someone from QA to validate it on a couple different distros with different disks mounted under /var/lib/rancher/ just to validate that I haven't missed anything - prior to merging.

• Sorry was passing by, can we just add a sh test for that ? instead of QA

maybe just simulate a disks mounted in some distros and creating the path( /var/lib/rancher/ ) and one test for a custom dir
then call the install and uninstall function
then just create a func to validate the uninstall was ok removing and not removing the expected dirs and the mountpoint ?

[dereknola]

Ignore centos 7 failure, I am handling it in a separate PR.