Remove deprecated use of wait. functions

[willdot]

Proposed Changes

The following functions have been deprecated (along with their replacements)

PollImmediateUntilWithContext is now PollUntilContextCancel

PollImmediateInfiniteWithContext is now PollUntilContextCancel

PollImmediateWithContext is now PollUntilContextTimeout

PollImmediate is now PollUntilContextTimeout

Since all of these functions that are being replaced as Immediate the immediate flag is being set as true.

Types of Changes

Verification

Testing

Linked Issues

#9321

User-Facing Change

Further Comments

[vitorsavian]

Hey @willdot, how are you? how its going with the PR?

[willdot]

Hey @willdot, how are you? how its going with the PR?

Hey @vitorsavian

Haven't had much time to look recently as I'm trying to find new work due to layoffs.

The status of this PR though, is that the continuous-integration/drone/pr stage is failing and I couldn't dig into the logs enough to work out why 🤷‍♂️

[vitorsavian]

Hey @willdot

I'm sorry for your layoff.

if you could rebase your branch, since for what I saw it's only one test that is failing on our CI and could be fixed with the rebase.

[willdot]

Hey @willdot

I'm sorry for your layoff.

if you could rebase your branch, since for what I saw it's only one test that is failing on our CI and could be fixed with the rebase.

Thanks

I've rebased (after some voodoo magic and problems with DCO commit signing) but everything looks to be in place now.

Does make the commit history look messy so if it's a problem, I don't mind starting fresh and creating a new branch with the changes (there aren't many changes so shouldn't take too long)

[vitorsavian]

Thanks

I've rebased (after some voodoo magic and problems with DCO commit signing) but everything looks to be in place now.

Does make the commit history look messy so if it's a problem, I don't mind starting fresh and creating a new branch with the changes (there aren't many changes so shouldn't take too long)

I think it will be a good idea to create a new one with the changes to not change our commit history

[willdot]

@vitorsavian Please see #10546

I'm away now for the weekend so can continue with any changes / fixes next week 😄