Skip to content

Conversation

ergec
Copy link

@ergec ergec commented Jan 16, 2013

  • Added translation for days after functionality in Turkish language
  • Added translation months and years in Turkish language for default functionality

* Added translation for days after functionality in Turkish language
* Added translation months and years in Turkish language for default functionality
@jzaefferer
Copy link
Owner

Related to my comment on #13 - I'm considering importing the language files form moment.js (MIT licensed). Can you check if their turkish translation looks good to you? https://github.com/timrwood/moment/blob/master/lang/tr.js#L52

@ergec
Copy link
Author

ergec commented Jan 25, 2013

Yes translations are ok but I noticed there is a slight problem with formatting dates. I'll report this to them too.

moment().format("MMM Do YY"); returns Jan 25th 13 for English which is ok but for Turkish it returns Oca 25'inci 13. We never read day with suffix. "Do MMMM YYYY" "MMMM Do YYYY" doesn't matter we read day as number 25 only, no suffix.

@Krinkle
Copy link
Contributor

Krinkle commented Jan 26, 2013

@jzaefferer Now that you mention it, momentjs. What value does jquery-prettydate provide over momentjs?

Looks like an opportunity to join forces, for the benefit of the user.

@jzaefferer jzaefferer mentioned this pull request Jan 28, 2013
@jzaefferer
Copy link
Owner

@Krinkle momentjs has the same problem as this project: translations are user contributed, so there's only a limited selection, with usually no way for the maintainer to verify the quality of any contributions. I'd rather replace both projects with support for relative times in Globalize, with a modular build, on top of CLDR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants