Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose fork and exec* functions. #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hellozyemlya
Copy link

os.py check for existence of this functions, but they are not exposed from posix module. Make them exposed to ensure that os module looks more like default "native" os module.

@jeff5
Copy link
Member

jeff5 commented Feb 2, 2020

Thanks for tying this. Travis shows a failure, but I think it is unconnected with the patch.

However, when it is applied locally, I get this when I try to use execv at the prompt (works in CPython 3):

>>> os.execv("C:\\Windows\\notepad.exe", ["test.tmp"])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NotImplementedError: egid

In Linux it seems to work, but my terminal is messed up (no echo).

There are no tests, which may be a matter of merging in from CPython stdlib. (What happens here is that, while a lot of tests come from lib-python, when we need to tweak one, we fork it into our ~/Lib, but then they fossilise.)

@jeff5 jeff5 added the queried Review awaits proposer's response. label Feb 2, 2020
@jeff5
Copy link
Member

jeff5 commented Jun 4, 2020

Unfortunately a PR (unlike an issue) cannot be transferred to the new official home at https://github.com/jython/jython. Keeping this open in the frozen-mirror to allow for further consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
queried Review awaits proposer's response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants