fix zone push master temp logic

jxg81 · Mar 20, 2023 · 8370384 · 8370384
1 parent aeaeecf
commit 8370384
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 16 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "private": false,
   "displayName": "Homebridge Actron Que",
   "name": "homebridge-actron-que",
-  "version": "1.2.7-beta.5",
+  "version": "1.2.7-beta.6",
   "description": "Homebridge plugin for controlling Actron Que controller systems",
   "license": "Apache-2.0",
   "repository": {

diff --git a/src/masterControllerAccessory.ts b/src/masterControllerAccessory.ts
@@ -2,7 +2,7 @@ import { Service, PlatformAccessory, CharacteristicValue, HAPStatus } from 'home
 import { ClimateMode, CompressorMode, FanMode, PowerState } from './types';
 import { ActronQuePlatform } from './platform';
 
-// This class represents the master controller, a separate class is used for representing zones (or will be once i write it)
+// This class represents the master controller, a separate class is used for representing zones
 export class MasterControllerAccessory {
   private hvacService: Service;
   private humidityService: Service;

diff --git a/src/zoneControllerAccessory.ts b/src/zoneControllerAccessory.ts
@@ -3,7 +3,7 @@ import { ClimateMode, CompressorMode } from './types';
 import { ActronQuePlatform } from './platform';
 import { HvacZone } from './hvacZone';
 
-// This class represents the master controller, a separate class is used for representing zones (or will be once i write it)
+// This class represents the zone controller
 export class ZoneControllerAccessory {
   private hvacService: Service;
   // some versions of the zone sensor do not support humidity
@@ -232,11 +232,12 @@ export class ZoneControllerAccessory {
         await this.platform.hvacInstance.setHeatTemp(value as number + 2);
         await this.platform.hvacInstance.getStatus();
       }
-    }
-    if (value > this.zone.maxHeatSetPoint) {
-      value = this.zone.maxHeatSetPoint;
-    } else if (value < this.zone.minHeatSetPoint) {
-      value = this.zone.minHeatSetPoint;
+    } else {
+      if (value > this.zone.maxHeatSetPoint) {
+        value = this.zone.maxHeatSetPoint;
+      } else if (value < this.zone.minHeatSetPoint) {
+        value = this.zone.minHeatSetPoint;
+      }
     }
     await this.zone.setHeatTemp(value as number);
     this.platform.log.debug(`Set Zone ${this.zone.zoneName} Target Heating Temperature -> `, value);
@@ -261,14 +262,14 @@ export class ZoneControllerAccessory {
         this.platform.log.debug(`Value is less than MIN cool set point of ${this.zone.minCoolSetPoint}, SETTING MASTER TO -> `, value);
         await this.platform.hvacInstance.getStatus();
       }
-    }
-    if (value > this.zone.maxCoolSetPoint) {
-      value = this.zone.maxCoolSetPoint;
-      this.platform.log.debug(`Value is greater than max cool set point of ${this.zone.maxCoolSetPoint}, CHANGING TO -> `, value);
-    } else if (value < this.zone.minCoolSetPoint) {
-      value = this.zone.minCoolSetPoint;
-      this.platform.log.debug(`Value is less than MIN cool set point of ${this.zone.minCoolSetPoint}, CHANGING TO -> `, value);
-
+    } else {
+      if (value > this.zone.maxCoolSetPoint) {
+        value = this.zone.maxCoolSetPoint;
+        this.platform.log.debug(`Value is greater than max cool set point of ${this.zone.maxCoolSetPoint}, CHANGING TO -> `, value);
+      } else if (value < this.zone.minCoolSetPoint) {
+        value = this.zone.minCoolSetPoint;
+        this.platform.log.debug(`Value is less than MIN cool set point of ${this.zone.minCoolSetPoint}, CHANGING TO -> `, value);
+      }
     }
     await this.zone.setCoolTemp(value as number);
     this.platform.log.debug(`Set Zone ${this.zone.zoneName} Target Cooling Temperature -> `, value);