Feat / Add new languages (nl/fr/de) #651
Conversation
|
Visit the preview URL for this PR (updated for commit a8b4255): https://ottwebapp--pr651-feat-new-languages-d2tl7s32.web.app (expires Sat, 29 Mar 2025 10:37:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
langemike
force-pushed
the
feat/new-languages
branch
from
a7ea57c to
e99d334
Compare
|
@ChristiaanScheermeijer @AntonLantukh - changed everything to formal tone in latest commit. I'll have a re-read at some time to make sure everything is gucci. Meanwhile have a great couple of christmas days |
|
Adjusted to the best of my abilities - @AntonLantukh @ChristiaanScheermeijer |
|
@morrieinmaas thanks a lot! |
| "pending_downgrade": "Diminution en attente", | ||
| "pending_offer_switch": "Sera mis à jour vers \"{{title}}\" après la prochaine date de facturation", | ||
| "price_paid_with": "{{price}} payé avec {{method}}", | ||
| "price_paid_with_card": "Prix payé avec carte", |
There was a problem hiding this comment.
Prix payé par carte, but we should use avec for cash payments. What are the potential methods in the line above?
There was a problem hiding this comment.
price_paid_with is used for all other payment methods which can be PayPal or In-app purchase. The price_paid_with_card is exclusively used for creditcard payments.
ChristiaanScheermeijer
force-pushed
the
feat/new-languages
branch
from
a9108de to
a8b4255
Compare
|
@qlecorre thank you very much for your help with this PR! 💪 I have processed most of your suggestions and commented on your questions. My goal is to merge this PR this week. Let me know if you are unavailable this week, then I will proceed with merging this PR and create a new issue for the remaining translation discussions. |
|
I have created #673 for the remaining feedback |
This change adds and activates 3 new languages:
I kept
us_state.jsonin English.These are all translated using ChatGTP.
Tickets: OTT-2756 & OTT-2763