Add support for separate horizontal/vertical swing modes #332
+122
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration, depends on home-assistant/core#125578 * custom_components/daikin_onecta/climate.py: * custom_components/daikin_onecta/const.py: * custom_components/daikin_onecta/icons.json: * custom_components/daikin_onecta/translations/el.json: * custom_components/daikin_onecta/translations/en.json: * custom_components/daikin_onecta/translations/nl.json: * custom_components/daikin_onecta/translations/sl.json:
* custom_components/daikin_onecta/icons.json:
* custom_components/daikin_onecta/translations/el.json:
* custom_components/daikin_onecta/translations/en.json:
* custom_components/daikin_onecta/translations/nl.json:
* custom_components/daikin_onecta/translations/sl.json:
* custom_components/daikin_onecta/translations/el.json:
* custom_components/daikin_onecta/translations/nl.json:
* custom_components/daikin_onecta/climate.py:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
===========================================
- Coverage 95.37% 10.74% -84.63%
===========================================
Files 14 14
Lines 1642 1610 -32
===========================================
- Hits 1566 173 -1393
- Misses 76 1437 +1361 ☔ View full report in Codecov by Sentry. |
|
Waits on the HA core changes to be finished and merged |
|
Needs tests for the new horizontal mode services, including the lower case logic |
* custom_components/daikin_onecta/climate.py:
* custom_components/daikin_onecta/climate.py:
* tests/test_init.py:
* tests/test_init.py:
* custom_components/daikin_onecta/icons.json:
Signed-off-by: Johnny Willemsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.