Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background colours #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove background colours #50

wants to merge 1 commit into from

Conversation

edg2s
Copy link

@edg2s edg2s commented Oct 28, 2020

Fixes #48

Copy link
Owner

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Does it work fine with the default, regular theme too?
edit: It seems to break in my system.

@edg2s
Copy link
Author

edg2s commented Dec 14, 2020

I'm using Ubuntu 20.04 and this is the default theme. Is there a way to change this, I can't seem to even with Gnome Tweaks.

@jwendell
Copy link
Owner

I don't know, haven't used Ubuntu in 10 years

@edg2s
Copy link
Author

edg2s commented Dec 14, 2020

Setting a background colour on the label seems incorrect either way. Shouldn't inherited styles have a sensible background and text colour combination already?

@lofidevops
Copy link

@jwendell Can you provide:

  • a screenshot of how it breaks on your system?
  • any hints about figuring out CSS inheritance in the context of GNOME Shell

I use this extension on PureOS (vanilla GNOME) and I'm now setting it up on an Ubuntu system.

So I'm keen to have it work in both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels not visible with dark text on light
3 participants