Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a 400 for requests missing form parameters #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return a 400 for requests missing form parameters #194

wants to merge 1 commit into from

Conversation

danielcompton
Copy link
Contributor

@danielcompton danielcompton commented Sep 1, 2017 •
edited
Loading

#125 added support for returning a 400 when the body of a request was empty and that didn't pass the :body resource schema. This commit extends that support to also handle requests where the schema is defined on the :form.

Relates to #110

@danielcompton
Return a 400 for requests missing form parameters
8bd3577 
juxt#125 added support for returning a 400 when the body of a request was
empty and that didn't pass the :body resource schema. This commit
extends that support to also handle requests where the schema is defined
on the :form.

Relates to juxt#110
@danielcompton
Copy link
Contributor Author

danielcompton commented Sep 1, 2017 •
edited
Loading

This causes the form-test tests to fail. I think I must be missing the distinction between :form and :body here. I would assume that requests for either that were missing form parameters would fail, but it seems like it is acceptable for :form to have missing params, but not :body?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielcompton