pass context through on interrupt handlers#91
Closed
localyost3000 wants to merge 1 commit intojustjake:mainfrom
Closed
pass context through on interrupt handlers#91localyost3000 wants to merge 1 commit intojustjake:mainfrom
localyost3000 wants to merge 1 commit intojustjake:mainfrom
Conversation
Owner
|
You could use a WeakMap<QuickJSContext, ContextInterruptHandler> to store your per-context interrupt. This kind of indirection is already how per-runtime interrupts are implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the instructions @justjake laid out in #84 to add context as an arg to runtime interrupt handlers. This is definitely a useful addition, but not quite to the context-level interrupts I want. Gonna play with this codepath some more to see if I can actually achieve separate interrupts per context. The biggest blocker I know of right now is that interrupt handlers only exist at the runtime level. This means I will need to do something like
this.runtime.setInterruptHander((runtime, context) => context === this ? cb(runtime, context) : this.runtime.interruptHandler?.(runtime, context) ?? false). This leads to a sort of russian nesting doll situation. I would much rather be able to set interrupts per context natively, or have multiple interrupts registered on a runtime