disable asyncify-advise, its just really spammy

justjake · Aug 31, 2024 · 2af655d · 2af655d
1 parent 31aa729
commit 2af655d
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 11 deletions.
diff --git a/packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile b/packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile
@@ -91,7 +91,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-extension.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js
-CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1
 CFLAGS_WASM+=-O3
 CFLAGS_CJS+=-s ENVIRONMENT=node
 CFLAGS_MJS+=-s ENVIRONMENT=node

diff --git a/packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md b/packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md
@@ -88,7 +88,6 @@ Variant-specific Emscripten build flags:
   "--pre-js $(TEMPLATES)/pre-sourceMapJson.js",
   "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js",
   "--pre-js $(TEMPLATES)/pre-wasmMemory.js",
-  "-s ASYNCIFY_ADVISE=1",
   "-O3"
 ]
 ```
diff --git a/packages/variant-quickjs-singlefile-browser-debug-asyncify/Makefile b/packages/variant-quickjs-singlefile-browser-debug-asyncify/Makefile
@@ -92,7 +92,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js
 CFLAGS_WASM+=-s SINGLE_FILE=1
-CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1
 CFLAGS_WASM+=-O3
 
 

diff --git a/packages/variant-quickjs-singlefile-browser-debug-asyncify/README.md b/packages/variant-quickjs-singlefile-browser-debug-asyncify/README.md
@@ -77,7 +77,6 @@ Variant-specific Emscripten build flags:
   "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js",
   "--pre-js $(TEMPLATES)/pre-wasmMemory.js",
   "-s SINGLE_FILE=1",
-  "-s ASYNCIFY_ADVISE=1",
   "-O3"
 ]
 ```
diff --git a/packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile b/packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile
@@ -92,7 +92,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js
 CFLAGS_WASM+=-s SINGLE_FILE=1
-CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1
 CFLAGS_WASM+=-O3
 CFLAGS_CJS+=-s ENVIRONMENT=web,worker,node
 

diff --git a/packages/variant-quickjs-singlefile-cjs-debug-asyncify/README.md b/packages/variant-quickjs-singlefile-cjs-debug-asyncify/README.md
@@ -77,7 +77,6 @@ Variant-specific Emscripten build flags:
   "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js",
   "--pre-js $(TEMPLATES)/pre-wasmMemory.js",
   "-s SINGLE_FILE=1",
-  "-s ASYNCIFY_ADVISE=1",
   "-O3"
 ]
 ```
diff --git a/packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile b/packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile
@@ -92,7 +92,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js
 CFLAGS_WASM+=-s SINGLE_FILE=1
-CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1
 CFLAGS_WASM+=-O3
 
 CFLAGS_MJS+=-s ENVIRONMENT=node

diff --git a/packages/variant-quickjs-singlefile-mjs-debug-asyncify/README.md b/packages/variant-quickjs-singlefile-mjs-debug-asyncify/README.md
@@ -77,7 +77,6 @@ Variant-specific Emscripten build flags:
   "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js",
   "--pre-js $(TEMPLATES)/pre-wasmMemory.js",
   "-s SINGLE_FILE=1",
-  "-s ASYNCIFY_ADVISE=1",
   "-O3"
 ]
 ```
diff --git a/packages/variant-quickjs-wasmfile-debug-asyncify/Makefile b/packages/variant-quickjs-wasmfile-debug-asyncify/Makefile
@@ -91,7 +91,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-extension.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js
 CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js
-CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1
 CFLAGS_WASM+=-O3
 CFLAGS_CJS+=-s ENVIRONMENT=node
 CFLAGS_MJS+=-s ENVIRONMENT=node

diff --git a/packages/variant-quickjs-wasmfile-debug-asyncify/README.md b/packages/variant-quickjs-wasmfile-debug-asyncify/README.md
@@ -88,7 +88,6 @@ Variant-specific Emscripten build flags:
   "--pre-js $(TEMPLATES)/pre-sourceMapJson.js",
   "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js",
   "--pre-js $(TEMPLATES)/pre-wasmMemory.js",
-  "-s ASYNCIFY_ADVISE=1",
   "-O3"
 ]
 ```
diff --git a/scripts/prepareVariants.ts b/scripts/prepareVariants.ts
@@ -223,7 +223,7 @@ function getCflags(targetName: string, variant: BuildVariant) {
         flags.push("-g2")
         break
       case SyncMode.Asyncify:
-        flags.push("-s ASYNCIFY_ADVISE=1")
+        // flags.push("-s ASYNCIFY_ADVISE=1")
         flags.push(
           // # Need to use -O3 - otherwise ASYNCIFY leads to stack overflows (why?)
           "-O3",