Fix for compile error "[...] undefined reference to `sd_obj' ": #479
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added HAS_SD to fix compile error: esp32_marauder/EvilPortal.cpp added FEBERIS Board to configs: esp32_marauder/configs.h
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: When using boards with no SD card with commented option "HAS_SD" in the config.h produced compile error: "[...]undefined reference to `sd_obj' ".
FIX: Added HAS_SD conditional inclusion in EvilPortal.cpp to fix the problem.
Things to consider:
I've added FEBERIS Board to configs.h. This board is getting more popular now, and I though maybe it could be added to master config.