fix overriding configuration #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome i can't wait to get this merged! The TableNotFoundException had been introduced in #125 Could you try the steps in that PR and see if it is no longer an issue with your current code? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that if you save the configuration within the administration, the sentry error reporting got disabled, because of the setting
sentry/environment/enabledthis PR will add another setting with which it is possible to enable to override.
Only if the override is enabled, it is possible to disable the Sentry error tracking.
Also reworked the
collectModuleConfigwithin the config-helper to make sure that values, which are null or empty, do not override the deployment configuration.I added
canRestoreto the system.xml to make sure that no empty values got stored into the database.I removed the TableNotFoundException-Handling, because i do not see a case when this could happen.