Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Modify the GitHub Actions workflow" docs #55

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

PatrickSt1991
Copy link
Contributor

Ruby-version should be 3.3, you already got that in your pages.yaml but not in the readme

for Upload artifact the path
needs to be path: docs/_site/
not path: "docs/_site/"

Ruby-version should be 3.3, you already got that in your pages.yaml but not in the readme

for Upload artifact the path 
needs to be path: docs/_site/
not "docs/_site/"
@mattxwang mattxwang changed the title Minor changes to readme, just for the sake of it Update "Modify the GitHub Actions workflow" docs Nov 28, 2024
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickSt1991 -- appreciate you catching this!

@mattxwang mattxwang merged commit b66ab71 into just-the-docs:main Nov 28, 2024
1 check passed
@PatrickSt1991 PatrickSt1991 deleted the patch-1 branch November 28, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants