Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions to versions using Node 20 #48

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Update GitHub Actions to versions using Node 20 #48

merged 2 commits into from
Jun 6, 2024

Conversation

lamasfoker
Copy link
Contributor

Github will soon remove Node 16 from the Github Action; see blog post. In this PR, I want to update the actions used in this workflow to the latest version in order to get rid of the warning message on action launches.

@lamasfoker
Copy link
Contributor Author

@mattxwang I just saw that an identical PR #46 is present. Feel free to close one and merge the other.

@mattxwang mattxwang changed the title Update Guthub Action to support Node 20 Update GitHub Actions to versions using Node 20 Jun 6, 2024
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @lamasfoker, and sorry for the delay! While there's an open PR, it seems like the author is inactive. I will merge this one in instead. Thank you for making your first contribution!

@mattxwang mattxwang merged commit 0314cb1 into just-the-docs:main Jun 6, 2024
5 checks passed
@IbrahimAH
Copy link

Thanks for this @lamasfoker. @mattxwang I saw your reply a while back but have just been too smashed at work to get around to it. Thanks for merging it in and closing off my PR, sorry for the delay!

@mattxwang
Copy link
Member

Thanks for this @lamasfoker. @mattxwang I saw your reply a while back but have just been too smashed at work to get around to it. Thanks for merging it in and closing off my PR, sorry for the delay!

No worries at all @IbrahimAH - I was also swamped with work, hence my late reply 😓 thank you for opening the PR that kickstarted this process!

@lamasfoker lamasfoker deleted the patch-1 branch June 10, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants