Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump just-the-docs from 0.8.1 to 0.8.2, bump transitive dependencies #45

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 2, 2024

Bumps just-the-docs from 0.8.1 to 0.8.2.

Changelog

Sourced from just-the-docs's changelog.

Release v0.8.2

Hi everyone! This patch release fixes a bug where a default layout with unrestricted scope (path: "") breaks JavaScript functionality. Users who do not use a default layout with unrestricted scope should not be affected. This should be a straightforward upgrade for all users. Thank you to [@​pdmosses] for triaging and fixing the bug!

Bugfixes

  • Fixed: Protect theme JS file from front matter default for layout by [@​pdmosses] in #1447

#1447: just-the-docs/just-the-docs#1447

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [just-the-docs](https://github.com/just-the-docs/just-the-docs) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/just-the-docs/just-the-docs/releases)
- [Changelog](https://github.com/just-the-docs/just-the-docs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/just-the-docs/just-the-docs/commits)

---
updated-dependencies:
- dependency-name: just-the-docs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 2, 2024
@mattxwang
Copy link
Member

Huh - there's an issue installing sass-embedded. Need to look into this when I have more cycles 😓

Not sure what's going on with `sass-embedded` here...
@mattxwang mattxwang changed the title Bump just-the-docs from 0.8.1 to 0.8.2 Bump just-the-docs from 0.8.1 to 0.8.2, bump transitive dependencies Apr 5, 2024
@mattxwang
Copy link
Member

Huh - on RubyGems, the gem still exists with the correct version 1.74.1-x86_64-linux-gnu. This is more complicated than I thought.

@mattxwang mattxwang force-pushed the dependabot/bundler/just-the-docs-0.8.2 branch 2 times, most recently from 2fe58f1 to eb0d86c Compare April 5, 2024 21:58
@mattxwang
Copy link
Member

Hm. It's not clear to me why the Netlify runner is trying to pull from https://rubygems.org/gems/sass-embedded-1.74.1-x86_64-linux.gem, given that the lockfile specifies the version as 1.74.1-x86_64-linux-gnu. Even if I change the PLATFORMS entry to x86_64-linux-gnu, it still only pulls with the linux suffix.

@mattxwang mattxwang force-pushed the dependabot/bundler/just-the-docs-0.8.2 branch from d3b6418 to ede5a9e Compare April 5, 2024 22:17
@mattxwang
Copy link
Member

I am ... so confused LOL. I hope whoever is following this thread gets a kick out of this.

I will look at this another time - ideally don't want to just ship 63ddce0, but it's not clear to me why ede5a9e fails when x86_64-linux was not removed as part of the pruned list or original list (it only specifies musl or android, neither of which is what I want).

@mattxwang
Copy link
Member

Ah! Okay, after some more triaging, this is a duplicate of and sass-contrib/sass-embedded-host-ruby#176 and sass-contrib/sass-embedded-host-ruby#187. The maintainer comments that

This is a known bug in older version of bundler/rubygems. The minimum require version is rubygems >=3.3.22 and bundler >=2.3.22.

I bumped the ruby version to 3.3.0 and regenerated the Gemfile.lock, and now this passes! I'm going to now trim down the platform list, but glad that this has been somewhat resolved 😓

@mattxwang
Copy link
Member

Okay, wow - this was a headache. This is GTM for now - it's unclear to me how these platform issues will ripple to our downstream users, but it's promising that this works on Netlify, Actions, and GitLab runners.

@mattxwang mattxwang merged commit 44d6027 into main Apr 17, 2024
5 checks passed
@mattxwang mattxwang deleted the dependabot/bundler/just-the-docs-0.8.2 branch April 17, 2024 23:45
mattxwang added a commit to just-the-docs/just-the-docs that referenced this pull request Apr 17, 2024
This PR essentially updates the "default" Ruby version to 3.3. In the process, it:

- fixes a bug with the linux platform for `sass-embedded`
- regenerates the `Gemfile.lock` with Bundler 2.5.9
- adds Ruby 3.3 to the testing matrix & updates our deployment actions to use Ruby 3.3
- removes Ruby 3.0 from the testing matrix, as it is now end of life

This PR is motivated by just-the-docs/just-the-docs-template#45, where I discovered that depending on the bundler/RubyGems version, the platform resolution for platformed gems can fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant