Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unneeded keymanager features #7357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dracarys18
Copy link
Member

Type of Change

  • Enhancement

Description

Remove unneeded features related to keymanager

Motivation and Context

This combined multiple feature flags of keymanager into one and also makes keymanager_mtls runtime configurable

How did you test it?

NA

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 requested review from a team as code owners February 24, 2025 09:44
Copy link

semanticdiff-com bot commented Feb 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/admin.rs  85% smaller
  crates/router/src/configs/secrets_transformers.rs  55% smaller
  crates/common_utils/src/keymanager.rs  53% smaller
  crates/router/src/configs/settings.rs  51% smaller
  crates/common_utils/src/lib.rs  50% smaller
  crates/router/src/configs/validations.rs  47% smaller
  crates/common_utils/src/types/keymanager.rs  41% smaller
  crates/common_utils/Cargo.toml Unsupported file format
  crates/common_utils/src/errors.rs  0% smaller
  crates/hyperswitch_domain_models/Cargo.toml Unsupported file format
  crates/hyperswitch_domain_models/src/type_encryption.rs  0% smaller
  crates/router/Cargo.toml Unsupported file format
  crates/router/src/types/domain/types.rs  0% smaller
  crates/router/src/types/domain/user.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant