-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cybersource): Add truncation logic for administrative area #7343
Open
cookieg13
wants to merge
1
commit into
main
Choose a base branch
from
cybersourceFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
Sakilmostak
reviewed
Feb 21, 2025
crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs
Outdated
Show resolved
Hide resolved
6dded85
to
043a1a0
Compare
043a1a0
to
b8b094c
Compare
Sakilmostak
approved these changes
Feb 21, 2025
cookieg13
commented
Feb 24, 2025
SanchithHegde
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scheduler changes look good to me!
mrudulvajpayee4935
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Cybersource throws error if state length exceeds 20 characters, to fix this this PR addes truncation of state at Hyperswitch end
Additional Changes
Motivation and Context
How did you test it?
Make /payments with state greater than 20 characters
Output
Checklist
cargo +nightly fmt --all
cargo clippy