Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add support for azure key vault as secret manager #7330

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rafee-Mohamed
Copy link

@Rafee-Mohamed Rafee-Mohamed commented Feb 20, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implement Azure key vault support for secret management and encryption management in external_services similar to the available AWS KMS, HashiCorp Vault, plaintext. This can be used to securely storing sensitive configuration settings.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #6181

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

Implement Azure key vault support for secret management and encryption management in external_services.
This can be used to securely storing sensitive configuration settings.

Fixes juspay#6181
@Rafee-Mohamed Rafee-Mohamed requested a review from a team as a code owner February 20, 2025 13:43
Copy link

semanticdiff-com bot commented Feb 20, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  Cargo.lock Unsupported file format
  crates/external_services/Cargo.toml Unsupported file format
  crates/external_services/src/azure_key_vault.rs  0% smaller
  crates/external_services/src/azure_key_vault/core.rs  0% smaller
  crates/external_services/src/azure_key_vault/implementers.rs  0% smaller
  crates/external_services/src/lib.rs  0% smaller

@Rafee-Mohamed
Copy link
Author

Rafee-Mohamed commented Feb 20, 2025

Hi everyone,

This is my first pull request to Hyperswitch. The issue is not yet fully resolved and require further guidance on resolving that. I have few doubts which I will raise in the issue comments. I would appreciate any feedback or review you may have.

Created Files:

  • crates/external_services/src/azure_key_vault.rs
  • crates/external_services/src/azure_key_vault/core.rs
  • crates/external_services/src/azure_key_vault/implementers.rs

Thank you!

@Rafee-Mohamed Rafee-Mohamed changed the title Add support for azure key vault as secret manager feat(router): add support for azure key vault as secret manager Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add new secrets manager implementation (Azure Key Vault)
1 participant