-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lazy connection pools for dynamic routing service #6437
Open
prajjwalkumar17
wants to merge
5
commits into
main
Choose a base branch
from
grpc-hyper-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 1 of 3 files. Overall, the semantic diff is 22% smaller than the GitHub diff.
|
NishantJoshi00
requested changes
Oct 25, 2024
NishantJoshi00
approved these changes
Oct 25, 2024
NishantJoshi00
approved these changes
Oct 25, 2024
Chethan-rao
approved these changes
Oct 25, 2024
SanchithHegde
approved these changes
Oct 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Previously hyperswitch server was panicking, if it wasn't able to establish a connection with dynamic_routing service. We have fixed this by establishing lazy connection pools and not established channel(which was previously). Which will insure hyperswitch server to run even when the connection isn't established.
Additional Changes
Motivation and Context
How did you test it?
Tested on my local.
This can't be tested on Integ as we don't have this service on integ.
Can't be tested on sbx as well, as it will require the pods to be killed. and a re-establishment of connection.
Checklist
cargo +nightly fmt --all
cargo clippy