Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy connection pools for dynamic routing service #6437

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Oct 25, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Previously hyperswitch server was panicking, if it wasn't able to establish a connection with dynamic_routing service. We have fixed this by establishing lazy connection pools and not established channel(which was previously). Which will insure hyperswitch server to run even when the connection isn't established.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested on my local.
Screenshot 2024-10-25 at 4 15 03 PM
This can't be tested on Integ as we don't have this service on integ.
Can't be tested on sbx as well, as it will require the pods to be killed. and a re-establishment of connection.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 added A-framework Area: Framework A-routing Area: Routing labels Oct 25, 2024
@prajjwalkumar17 prajjwalkumar17 added this to the October 2024 Release milestone Oct 25, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Oct 25, 2024
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner October 25, 2024 10:47
Copy link

semanticdiff-com bot commented Oct 25, 2024

Review changes with SemanticDiff.

Analyzed 1 of 3 files.

Overall, the semantic diff is 22% smaller than the GitHub diff.

Filename Status
Cargo.lock Unsupported file format
crates/external_services/Cargo.toml Unsupported file format
✔️ crates/external_services/src/grpc_client/dynamic_routing.rs 21.85% smaller

@prajjwalkumar17 prajjwalkumar17 linked an issue Oct 25, 2024 that may be closed by this pull request
@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Area: Framework A-routing Area: Routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: lazy connection pools for dynamic routing service
4 participants