Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): added amount conversion to FISERV #6256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(connector): added amount conversion to FISERV #6256

wants to merge 3 commits into from

Conversation

ravikiran232
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added MinorUnit for amount conversion

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

fixes #5947

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ravikiran232 ravikiran232 requested review from a team as code owners October 8, 2024 03:28
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 8, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 5 of 5 files.

Overall, the semantic diff is 33% smaller than the GitHub diff.

Filename Status
✔️ crates/router/tests/connectors/fiserv.rs 61.68% smaller
✔️ crates/router/src/types/api.rs 71.69% smaller
✔️ crates/hyperswitch_connectors/src/utils.rs Analyzed
✔️ crates/hyperswitch_connectors/src/connectors/fiserv.rs 23.91% smaller
✔️ crates/hyperswitch_connectors/src/connectors/fiserv/transformers.rs 48.08% smaller

@gorakhnathy7 gorakhnathy7 added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 15, 2024
deepanshu-iiitu
deepanshu-iiitu requested changes Oct 17, 2024
View reviewed changes
crates/hyperswitch_connectors/src/utils.rs
@@ -120,6 +120,7 @@ pub(crate) fn construct_not_implemented_error_report(
.into()
}

#[allow(dead_code)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

@deepanshu-iiitu
Copy link
Contributor

@ravikiran232 Please implement the suggested changes.

@gorakhnathy7
Copy link
Collaborator

Hey @ravikiran232 Any updates on the changes!

@gorakhnathy7 gorakhnathy7 added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2024
@itsharshvb itsharshvb mentioned this pull request Feb 21, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu requested changes

@ImSagnik007 ImSagnik007 Awaiting requested review from ImSagnik007

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Requested changes must be addressed to merge this pull request.

Assignees

@ravikiran232 ravikiran232

Labels
hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [FISERV] Add amount conversion framework to Fiserv
3 participants
@ravikiran232 @deepanshu-iiitu @gorakhnathy7