-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CD Pipeline Using Argo for hyperswitch-helm #83
base: main
Are you sure you want to change the base?
Conversation
|
||
# Controls when the workflow will run | ||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abhinavtyagiO
How are you planning to do the release for a particular version and rollout updates via workflows, will you be able to connect with your cluster via github CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On changing the image in values.yml, argo has an auto-sync policy which brings up pods with the new image based on the rolling strategy. And, yes, we can connect to the cluster if the cluster is public or if the workflow is using a runner that has access to the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have this tested this before?
- Configuration of the certificates for the TLS endpoints is required explicitly. | ||
- Install the ArgoCD CLI. For MacOS, it is | ||
``` | ||
brew install argocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of installing argocd manually, we can add it as dependant chart
https://github.com/bitnami/charts/tree/main/bitnami/argo-cd/ and keep it within hyperswitch-cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, better approach. I have added it in the latest commit.
@@ -0,0 +1,37 @@ | |||
apiVersion: argoproj.io/v1alpha1 | |||
kind: ApplicationSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we use this applicationset without chart.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the chart.yml in hyperswitch-cd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,37 @@ | |||
apiVersion: argoproj.io/v1alpha1 | |||
kind: ApplicationSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the expectation is to have the individual hyperswitch services running with the help of argocd, ApplicationSet defined here is no way connected to the helm chart, how this will be added to kubernetes on running helm install
inside the charts/incubator/hyperswitch-cd folder
No description provided.