Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CD Pipeline Using Argo for hyperswitch-helm #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abhinavtyagiO
Copy link

No description provided.


# Controls when the workflow will run
on:
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhinavtyagiO
How are you planning to do the release for a particular version and rollout updates via workflows, will you be able to connect with your cluster via github CI?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On changing the image in values.yml, argo has an auto-sync policy which brings up pods with the new image based on the rolling strategy. And, yes, we can connect to the cluster if the cluster is public or if the workflow is using a runner that has access to the cluster.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this tested this before?

- Configuration of the certificates for the TLS endpoints is required explicitly.
- Install the ArgoCD CLI. For MacOS, it is
```
brew install argocd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of installing argocd manually, we can add it as dependant chart
https://github.com/bitnami/charts/tree/main/bitnami/argo-cd/ and keep it within hyperswitch-cd

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better approach. I have added it in the latest commit.

@@ -0,0 +1,37 @@
apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we use this applicationset without chart.yaml?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the chart.yml in hyperswitch-cd.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm expects the file name to be Chart.yaml. Also the dependency added is incorrect, please check the dependency and test it in your local first.

I tried testing these faced below error
Screenshot 2024-04-08 at 13 19 22

@@ -0,0 +1,37 @@
apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the expectation is to have the individual hyperswitch services running with the help of argocd, ApplicationSet defined here is no way connected to the helm chart, how this will be added to kubernetes on running helm install inside the charts/incubator/hyperswitch-cd folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants