Skip to content

Commit

Permalink
Add test to extras_require and remove dev-requirements.txt
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Jan 25, 2024
1 parent b21f9ae commit b2596bb
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
- name: Install Python dependencies
run: |
pip install --upgrade setuptools pip
pip install -r dev-requirements.txt -e .
pip install -e ".[test]"
- name: List Python dependencies
run: |
Expand Down
6 changes: 1 addition & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,10 @@ This package requires Python >= 3.6.

As a Python package, you can set up a development environment by cloning this repo and running:

python3 -m pip install --editable .
python3 -m pip install --editable ".[test]"

from the repo directory.

You can also install the tools we use for testing and development with:

python3 -m pip install -r dev-requirements.txt

### Auto-format with pre-commit

We use the [pre-commit](https://pre-commit.com) tool for autoformatting.
Expand Down
10 changes: 0 additions & 10 deletions dev-requirements.txt

This file was deleted.

9 changes: 9 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@
# see https://github.com/jupyterhub/traefik-proxy/issues/155 for more
"consul": ["python-consul2"],
"etcd": ["etcdpy"],
"test": [
"jupyterhub-traefik-proxy[redis,etcd,consul]",
"certipy",
"notebook>=4.0",
"pytest",
"pytest-asyncio>=0.17,<0.23", # FIXME: unpin pytest-asyncio
"pytest-cov",
"websockets",
],
},
python_requires=">=3.8",
author="Project Jupyter Contributors",
Expand Down

0 comments on commit b2596bb

Please sign in to comment.