Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register existing signal handlers in simpervisor's atexit module #39

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Register existing signal handlers in simpervisor's atexit module #39

wants to merge 10 commits into from
+106 −7

Commits on Jun 27, 2023

  1. Take existing signal handlers into account 

    Ensure that we do not override the existing signal handlers registered
in Python
    @mahendrapaipuri
    mahendrapaipuri committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5999f60 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Ensure existing handlers are not default ones 

    We check if the existing handlers for SIGINT and SIGTERM are different
from default handlers.

Only when they are custom handlers, we execute them in our custom
handler
    @mahendrapaipuri
    mahendrapaipuri committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b52fd8d View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7e17032 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Cleanup commented out print statement

    @consideRatio
    consideRatio committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7b3dd30 View commit details
    Browse the repository at this point in the history

  2. Refactor for readability

    @consideRatio
    consideRatio committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    15304ee View commit details
    Browse the repository at this point in the history

  3. Fix calling of previous signal handlers for windows

    @consideRatio
    consideRatio committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0c1be62 View commit details
    Browse the repository at this point in the history

  4. Pass args to previous registered signal handlers 

    I'm not confident this is right, but not confident on the passing None
either. What is correct here?
    @consideRatio
    consideRatio committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4d2e774 View commit details
    Browse the repository at this point in the history

  5. Fix critical typo

    @consideRatio
    consideRatio committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3461767 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. test: Add a unit test for non default handlers 

    * Test will check if registered non default handlers are called

* Cast port number to int in simplehttpserver.py script

Signed-off-by: Mahendra Paipuri <[email protected]>
    @mahendrapaipuri
    mahendrapaipuri committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e1265cd View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0788834 View commit details
    Browse the repository at this point in the history